fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses#4745
Merged
NathanFlurry merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
This was referenced Apr 24, 2026
Merged
Member
Author
This was referenced Apr 24, 2026
Review: fix(rivetkit-core): abort graceful cleanup task when grace deadline elapsesSmall, focused fix adds a shutdown_deadline cancellation token so NAPI adapter cleanup work can be raced against the grace period deadline. Correctness
Naming nitcancel_shutdown_deadline reads as cancel/prevent the deadline rather than fire/trigger it. Test coverageNo tests added. A test for the slow-callback-abandoned-at-deadline path would strengthen confidence. Overall the approach is clean and correct. No blocking issues. |
a8c2068 to
7be35f1
Compare
2b7d922 to
04fb3f4
Compare
7be35f1 to
734fc88
Compare
04fb3f4 to
645f8a4
Compare
734fc88 to
efecd06
Compare
645f8a4 to
77297b3
Compare
This was referenced Apr 24, 2026
Merged
Merged
77297b3 to
ee89168
Compare
3 tasks
Contributor
Preview packages published to npmInstall with: npm install rivetkit@pr-4745All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-dd74d75
docker pull rivetdev/engine:full-dd74d75Individual packagesnpm install rivetkit@pr-4745
npm install @rivetkit/react@pr-4745
npm install @rivetkit/rivetkit-napi@pr-4745
npm install @rivetkit/workflow-engine@pr-4745 |
This was referenced Apr 24, 2026
This was referenced Apr 27, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: